Use title in blog post URLs again #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for silver-smakager-d8f15e ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The hashes don't seem to get escaped anymore when used as part of `:title` in a slug configuration. Since there aren't that many pages that are affected, we set the URL manually for those.
k-nut
force-pushed
the
use-title-in-urls
branch
from
94fcf67
to
8fe42c9
Compare
Should no longer be necessary with the new setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that with the unpinning of the hugo version in 2732566 and the updating of the dates in 627e1dd, something in hugo changed with regards to how it generates slugs.
The hugo documentation says regarding slugs:
It seems like something in our setup made it not take into account the
titlefrom the frontmatter anymore though. I have hence changed the configuration to explicitly use the title instead. This now causes problems because hugo doesn't escape hashes and creates filenames which won't render to valid URLs (see this issue) So I had add someurlfields manually to force escaped URLs for blog posts hat have hashes in their titles.All in all, this should hopefully restore the old structure that everything was rendered in before the upgrade.