Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add is_crew attribute to users to differ between employee and admin access #886

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

krmax44
Copy link
Member

@krmax44 krmax44 commented Nov 4, 2024

is_staff is required for accessing the admin, which may also be non-staff

@pajowu
Copy link
Member

pajowu commented Nov 4, 2024

Should we use a different name than is_staff for this, since it has a clear meaning in the django-world?

@krmax44
Copy link
Member Author

krmax44 commented Nov 8, 2024

Bit tricky, most synonyms are also used up (team, org). What about is_crew?

@pajowu
Copy link
Member

pajowu commented Nov 15, 2024

I like it

@krmax44
Copy link
Member Author

krmax44 commented Nov 18, 2024

also moved it from auth helpers directly to the user model, take a look @pajowu

@krmax44 krmax44 changed the title ✨ allow specification of staff group instead of User.is_staff for @is_staff ✨ add is_crew attribute to users to differ between employee and admin access Nov 18, 2024
@krmax44 krmax44 merged commit 484ca10 into main Nov 18, 2024
3 checks passed
@krmax44 krmax44 deleted the krmax44/staff-group branch November 18, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants