Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core/completion] Support scalar COMPREPLY with compgen -F #2212

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

akinomyoga
Copy link
Collaborator

With the current master branch,

$ bash -c '_test() { unset -v COMPREPLY; COMPREPLY=hello; }; compgen -F _test 2>/dev/null'
hello
$ bin/osh -c '_test() { unset -v COMPREPLY; COMPREPLY=hello; }; compgen -F _test 2>/dev/null'
$

This also includes a refactoring commit da6a6c1. After that, the main change is introduced in commit 87c4e62.

@akinomyoga akinomyoga changed the base branch from master to soil-staging January 2, 2025 12:46
Copy link
Contributor

@andychu andychu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thank you!

core/completion.py Outdated Show resolved Hide resolved
@andychu andychu merged commit eadacc6 into soil-staging Jan 2, 2025
18 checks passed
@akinomyoga akinomyoga deleted the fix-compgen branch January 2, 2025 16:14
@akinomyoga
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants