[ysh] Implement SparseArray $[sp1 === sp2], append ... (sp), and $[bool(sp)]
#2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andychu
reviewed
Dec 31, 2024
core/bash_impl.py
Outdated
| if len_lhs != len_rhs: | ||
| return False | ||
|
|
||
| for index in lhs.d.keys(): |
There was a problem hiding this comment.
We can remove .keys() here, since it will make a copy
In Python dictionaries iterate over their keys by default (which is unlike Go, which may be confusing!)
There was a problem hiding this comment.
There was a problem hiding this comment.
I updated it: 1121bfd..6726ba3
akinomyoga
force-pushed
the
SparseArray-ysh
branch
from
1121bfd to
6726ba3
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit corresponds to
$[sp1 === sp2],append ... (sp), or$[bool(sp)].