-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement multiple File uploading #9814
Open
DonXavierdev
wants to merge
27
commits into
ohcnetwork:develop
Choose a base branch
from
DonXavierdev:issues/7417/File-upload-enhancement
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
fbbd353
Implement multiple File uploading
DonXavierdev f136465
Added jspdf to package.json
DonXavierdev 21cd51d
Implement multiple File uploading
DonXavierdev a757ad5
Added jspdf to package.json
DonXavierdev f478af1
Merge branch 'issues/7417/File-upload-enhancement' of https://github.…
DonXavierdev 1c20535
Merge branch 'develop' into issues/7417/File-upload-enhancement
DonXavierdev 1dbf18f
Add jspdf to package.json
DonXavierdev 5fe1f64
Merge branch 'issues/7417/File-upload-enhancement' of https://github.…
DonXavierdev ece5d70
resolve package-lock.json
DonXavierdev 467cf59
Merge branch 'develop' of https://github.com/DonXavierdev/care_fe int…
DonXavierdev 5d65539
Merge branch 'issues/7417/File-upload-enhancement' of https://github.…
DonXavierdev 8014bf8
Remove duplicates package-lock.json
DonXavierdev 74186e6
remove extra space package.json
DonXavierdev 18bb454
package-lock.json mistake solved
DonXavierdev da64eb4
Merge branch 'develop' of https://github.com/DonXavierdev/care_fe int…
DonXavierdev 5141210
Merge branch 'develop' of https://github.com/DonXavierdev/care_fe int…
DonXavierdev 127acde
Add PDF combination feature to file upload
DonXavierdev 14d397f
Add error handling for PDF generation + Reset isPdf wherever necessary
DonXavierdev f1c77d2
Add checkbox For image to pdf conversion.
DonXavierdev 677fd46
Indicate file conversion progress,replace checkbox shadcn
DonXavierdev 66ddf42
Seperate Textbox for CombineToPdf and replace textbox with input shadcn
DonXavierdev cec95d7
Merge Branch with Main
DonXavierdev cc6e0d8
Add missing jspdf dependency
DonXavierdev eb5b3c2
Use Shadcn Label instead or normal label tag
DonXavierdev 0c77702
Merge branch 'develop' of https://github.com/DonXavierdev/care_fe int…
DonXavierdev e59ef78
fix: rename error variable in useFileUpload hook for clarity
DonXavierdev 84d9bd7
Fix Deploy preview failure
DonXavierdev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should only be adding jspdf 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if i remove other dependencies like atob,canvg etc. When user installs using "npm install" jspdf automatically installs the necessary dependencies into the package-lock.json file. What should i do about it. @Jacobjeevan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it's fine (to include them) 👍 Make sure only those are affected though.