Fix the Facilties tab overflow in Organization Layout #9778

AnveshNalimela · 2025-01-06T05:36:50Z

Proposed Changes

Fixes Facilties Tab overflow in Home page #9775
Change 1
Change 2
More?

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

Internationalization
- Added translation support for text in the Organizations view.
- Replaced hardcoded strings with translatable text.
UI/UX Improvements
- Enhanced layout responsiveness for organization cards and search input.
- Adjusted padding and container widths for better visual consistency.
- Updated the Menubar styling to occupy full width and height with horizontal overflow.

coderabbitai · 2025-01-06T05:36:58Z

Warning

Rate limit exceeded

@AnveshNalimela has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 31 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between b601ee4 and e92876e.

📒 Files selected for processing (1)

src/pages/FacilityOrganization/FacilityOrganizationView.tsx (5 hunks)

Walkthrough

This pull request involves two primary changes: styling updates to the OrganizationLayout component and internationalization improvements in the FacilityOrganizationView component. The Menubar in OrganizationLayout receives a new className to manage width, height, and horizontal overflow. In FacilityOrganizationView, translation functions are integrated for text localization, and layout responsiveness is enhanced through refined CSS classes.

Changes

File	Change Summary
`src/pages/Organization/components/OrganizationLayout.tsx`	Added `className="w-full h-full overflow-x-auto"` to `<Menubar>` for improved styling
`src/pages/FacilityOrganization/FacilityOrganizationView.tsx`	- Integrated `t()` for internationalization of text strings - Updated search input container layout - Modified card padding and organization name container width

Assessment against linked issues

Objective	Addressed	Explanation
Facilities Tab Overflow [#9775]	❓	Partial layout changes made, but direct resolution for tab overflow not explicitly confirmed

Possibly related PRs

Horizontal scroll bar used #9692: Organization selector component styling modifications
Care Loading icon in organization and facility users #9723: Organization layout improvements in loading and localization
Fix Online Status Indicator in Organization Tab #9728: UI component enhancements with localization

Suggested labels

needs review, needs testing

Suggested reviewers

rithviknishad
Jacobjeevan

Poem

🐰 Hop, hop, through code's domain,
Styling and text, no longer plain!
Menubar flows, translations sing,
A rabbit's touch makes features wing! 🌈
Code evolves with playful might! 🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-01-06T05:37:10Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`e92876e`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67812c69d246bb00086edde3
😎 Deploy Preview	https://deploy-preview-9778--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

AnveshNalimela · 2025-01-06T05:51:28Z

rithviknishad · 2025-01-06T06:25:50Z

let's improve this, something feels off about this.

AnveshNalimela · 2025-01-06T06:37:29Z

let's improve this, something feels off about this.

AnveshNalimela · 2025-01-06T06:45:53Z

rithviknishad · 2025-01-06T07:27:21Z

the search field is too small in mobile screens now.

rithviknishad · 2025-01-06T07:27:50Z

follow consistent designs with how it's there in other pages

AnveshNalimela · 2025-01-07T12:10:51Z

@rithviknishad

Jacobjeevan · 2025-01-09T10:47:51Z

Check multiple devices from the device list (browser) 👍

github-actions · 2025-01-09T14:51:30Z

👋 Hi, @AnveshNalimela,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

…s-tab

…shNalimela/care_fe into issue/ohcnetwork#9775/facilties-tab

Added a scroll-bar

4534f4e

AnveshNalimela requested a review from a team as a code owner January 6, 2025 05:36

AnveshNalimela marked this pull request as draft January 6, 2025 05:37

AnveshNalimela added 3 commits January 6, 2025 11:24

Fixed the organization layout irrepososive in mobile view

bdcbbec

Added translations

200f8e4

Added translations

97c09c5

AnveshNalimela marked this pull request as ready for review January 6, 2025 06:13

Changed from flex-row to col in mobile view

c3305f0

Jacobjeevan added the changes required label Jan 6, 2025

AnveshNalimela added 3 commits January 6, 2025 17:58

Merge branch 'develop' into issue/ohcnetwork#9775/facilties-tab

9e0a182

Made the requested changes

3158974

Merge branch 'develop' into issue/ohcnetwork#9775/facilties-tab

eb0c561

AnveshNalimela added 2 commits January 9, 2025 16:23

Merge branch 'develop' into issue/ohcnetwork#9775/facilties-tab

644b086

Updated the Layout

213fbd5

github-actions bot added the merge conflict pull requests with merge conflict label Jan 9, 2025

Made the changes

27b8026

github-actions bot removed the merge conflict pull requests with merge conflict label Jan 10, 2025

AnveshNalimela and others added 2 commits January 10, 2025 19:35

Made the Layout complteley checked on all screens

1944f6b

Merge branch 'ohcnetwork:develop' into issue/ohcnetwork#9775/faciltie…

b601ee4

…s-tab

AnveshNalimela added 2 commits January 10, 2025 19:48

i18n translations added

e4e3b54

Merge branch 'issue/ohcnetwork#9775/facilties-tab' of github.com:Anve…

e92876e

…shNalimela/care_fe into issue/ohcnetwork#9775/facilties-tab

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the Facilties tab overflow in Organization Layout #9778

Fix the Facilties tab overflow in Organization Layout #9778

AnveshNalimela commented Jan 6, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 6, 2025 •

edited

Loading

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Jan 6, 2025 •

edited

Loading

AnveshNalimela commented Jan 6, 2025

rithviknishad commented Jan 6, 2025

AnveshNalimela commented Jan 6, 2025

AnveshNalimela commented Jan 6, 2025

rithviknishad commented Jan 6, 2025

rithviknishad commented Jan 6, 2025

AnveshNalimela commented Jan 7, 2025

Jacobjeevan commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025

Fix the Facilties tab overflow in Organization Layout #9778

Are you sure you want to change the base?

Fix the Facilties tab overflow in Organization Layout #9778

Conversation

AnveshNalimela commented Jan 6, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Jan 6, 2025 • edited Loading

Rate limit exceeded

Walkthrough

Changes

Assessment against linked issues

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Jan 6, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

AnveshNalimela commented Jan 6, 2025

rithviknishad commented Jan 6, 2025

AnveshNalimela commented Jan 6, 2025

AnveshNalimela commented Jan 6, 2025

rithviknishad commented Jan 6, 2025

rithviknishad commented Jan 6, 2025

AnveshNalimela commented Jan 7, 2025

Jacobjeevan commented Jan 9, 2025 • edited Loading

github-actions bot commented Jan 9, 2025

AnveshNalimela commented Jan 6, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 6, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jan 6, 2025 •

edited

Loading

Jacobjeevan commented Jan 9, 2025 •

edited

Loading