add online status for authenticated user to true

[Agastya18]

Proposed Changes

add online true for authenticated user by updating the isUserOnline function in utils.ts

• Fixes Incorrect online status for authenticated account's profile #9570
• Change 1
• Change 2
• More?

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

• Add specs that demonstrate bug / test a new feature.
• Update product documentation.
• Ensure that UI text is kept in I18n files.
• Prep screenshot or demo video for changelog entry, and attach it to issue.
• Request for Peer Reviews
• Completion of QA

Summary by CodeRabbit

• New Features

  • Enhanced user online status determination by incorporating authentication checks.

• Bug Fixes

  • Improved logic for user status evaluation based on authentication and last login time.

[coderabbitai]

Walkthrough

The pull request modifies the isUserOnline utility function in src/Utils/utils.ts. The primary change introduces an optional isAuthenticated parameter to the function's type definition. When a user is authenticated, the function now immediately returns true, bypassing the previous time-based online status check. For non-authenticated users, the function continues to use the existing last_login time-based validation.

Changes

File	Change Summary
src/Utils/utils.ts	Updated isUserOnline function signature to include optional isAuthenticated parameter and modified logic to prioritize authentication status

Assessment against linked issues

Objective	Addressed	Explanation
Always show online for authenticated accounts [#9570]	✅

Poem

🐰 A rabbit's tale of online might,
Where auth status shines ever bright!
No more checking time's old track,
Authenticated users, welcome back!
Online status now crystal clear! 🌟

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	8d310f9
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/676d0ac328646c0008b8f6ef
😎 Deploy Preview	https://deploy-preview-9573--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/Utils/utils.ts (1)

220-223: Consider making the isAuthenticated property mandatory.

Currently, isAuthenticated is optional, but it significantly alters the logic of isUserOnline. To eliminate ambiguity, consider making this property mandatory or documenting the expected default behavior clearly if it’s omitted.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20fe265 and 8d310f9.

📒 Files selected for processing (1)

• src/Utils/utils.ts (1 hunks)

🔇 Additional comments (1)

src/Utils/utils.ts (1)

224-224: Verify unconditional override of the time-based check.

If user.isAuthenticated is true, the function always returns true, skipping the five-minute last_login check. Confirm that this is intentional and aligns with your product requirements, as it always treats authenticated users as “online” regardless of last_login.

[rithviknishad]

Closing as didn't solve the issue. isAuthenticated doesn't exist in user object.

Feel free to re-open once changes are made and do test yourself.