Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show details of patient in live feed monitoring #7545

Closed
wants to merge 7 commits into from

Conversation

rash-27
Copy link
Contributor

@rash-27 rash-27 commented Apr 5, 2024

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@rash-27 rash-27 requested a review from a team as a code owner April 5, 2024 03:31
Copy link

vercel bot commented Apr 5, 2024

@rash-27 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Apr 5, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3d26ddf
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/662a618a2cc4d500081aa1b0
😎 Deploy Preview https://deploy-preview-7545--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

@rash-27 fix the lint issue

@rash-27

This comment was marked as resolved.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 18, 2024
Copy link

👋 Hi, @rash-27,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rash-27
Copy link
Contributor Author

rash-27 commented Apr 19, 2024

@Nihal lint issued fixed, please have a look

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Apr 20, 2024
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The alignments of the preset selects seems to be broken. Ensure it's properly centered.
  2. Can we improve the design? Placing name, age and gender in a congested manner while lot of space is available besides it, seems to look not good.

@rash-27
Copy link
Contributor Author

rash-27 commented Apr 24, 2024

Yup , will improve the design ASAP .

@rash-27
Copy link
Contributor Author

rash-27 commented Apr 25, 2024

hey @rithviknishad is this ok? , Can we also display no patient text whenever a patient is not present ?
Screencast from 25-04-24 08:00:58 PM IST.webm

Copy link

github-actions bot commented May 5, 2024

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 5, 2024
Copy link

Hi, @coronasafe/care-frontend-maintainers, This PR has been automatically closed due to inactivity. Thank you for your contributions. Feel free to re-open the PR.

@github-actions github-actions bot closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Patient details of selected Preset in Location Live Feed Monitoring
4 participants