Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #7316 : header is redesigned to be consistent in all pages #7324

Closed
wants to merge 7 commits into from

Conversation

bishwas-10
Copy link

@bishwas-10 bishwas-10 commented Mar 2, 2024

#7316
header is redesigned to be consistent across all pages #7316

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

image
image
image
image
image
image
image
image

@bishwas-10 bishwas-10 requested a review from a team as a code owner March 2, 2024 16:43
Copy link

vercel bot commented Mar 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 9:54am

Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 01faba2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65e83d2dd526e20008d49d4e
😎 Deploy Preview https://deploy-preview-7324--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bishwas-10 bishwas-10 changed the title header is redesigned to be consistent in all pages #7316 fix #7316 : header is redesigned to be consistent in all pages Mar 2, 2024
@bishwas-10 bishwas-10 closed this Mar 3, 2024
@bishwas-10 bishwas-10 reopened this Mar 3, 2024
@bishwas-10 bishwas-10 closed this Mar 3, 2024
@bishwas-10 bishwas-10 reopened this Mar 3, 2024
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the lint errors:

npm run lint-fix

Copy link

github-actions bot commented Mar 4, 2024

👋 Hi, @bishwas-10,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Mar 4, 2024
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bishwas-10 Create a reusable component that can be used by all pages instead. This way it'd be way easier to ensure all main pages have consistent design.

@rithviknishad
Copy link
Member

@bishwas-10 Kindly request/wait for issue to be assigned before working on it.

@bishwas-10
Copy link
Author

@rithviknishad ok from here onwards i will be waiting for it to be assigned .!
can i work on the requested changes you ask to change ?

@rithviknishad
Copy link
Member

can i work on the requested changes you ask to change ?
yup!

@bishwas-10 bishwas-10 closed this Mar 4, 2024
@bishwas-10 bishwas-10 reopened this Mar 4, 2024
@bishwas-10
Copy link
Author

@rithviknishad can you please review this !!

@bishwas-10 bishwas-10 requested a review from Ashesh3 March 4, 2024 09:41
@rithviknishad
Copy link
Member

@bishwas-10 Create a reusable component that can be used by all pages instead. This way it'd be way easier to ensure all main pages have consistent design.

This is still not addressed

@bishwas-10
Copy link
Author

@rithviknishad so you mean to make the whole header reusable?

@rithviknishad
Copy link
Member

Yup! That's the easy way to make the design consistent and easier to maintain as per the issues requirements.

@bishwas-10
Copy link
Author

@rithviknishad please have a look

@rithviknishad
Copy link
Member

@bishwas-10

Already multiple other contributors have commented on the related issue to work on this, but was never assigned to them as a mock-up was not submitted. As mentioned in the issue comment you need to drop a mockup in the issue and request to be assigned before working on it.

As per message shared in the slack it is a recommended practice to get the issue assigned before working on it.

cc: @nihal467 @sainak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold merge conflict pull requests with merge conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants