-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #7316 : header is redesigned to be consistent in all pages #7324
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the lint errors:
npm run lint-fix
👋 Hi, @bishwas-10, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bishwas-10 Create a reusable component that can be used by all pages instead. This way it'd be way easier to ensure all main pages have consistent design.
@bishwas-10 Kindly request/wait for issue to be assigned before working on it. |
@rithviknishad ok from here onwards i will be waiting for it to be assigned .! |
|
@rithviknishad can you please review this !! |
This is still not addressed |
@rithviknishad so you mean to make the whole header reusable? |
Yup! That's the easy way to make the design consistent and easier to maintain as per the issues requirements. |
@rithviknishad please have a look |
Already multiple other contributors have commented on the related issue to work on this, but was never assigned to them as a mock-up was not submitted. As mentioned in the issue comment you need to drop a mockup in the issue and request to be assigned before working on it. As per message shared in the slack it is a recommended practice to get the issue assigned before working on it. |
#7316
header is redesigned to be consistent across all pages #7316
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers