Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #6504; fix sign out issue #6559

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Nov 7, 2023

WHAT

🤖 Generated by Copilot at 258fdcf

Fixed sign out redirection bug by using the same url variable and adding an else branch in handleSignOut function in src/Utils/utils.ts.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 258fdcf

  • Fix sign out bug by using consistent url variable and adding else branch to condition (link)

@rithviknishad rithviknishad requested a review from a team November 7, 2023 11:34
@rithviknishad rithviknishad requested a review from a team as a code owner November 7, 2023 11:34
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Nov 7, 2023 11:34am

Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 258fdcf
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/654a20bcda2b690009c2dd7b
😎 Deploy Preview https://deploy-preview-6559--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Nov 7, 2023

Passing run #1533 ↗︎

0 82 0 0 Flakiness 0

Details:

fixes #6504; fix sign out issue
Project: CARE Commit: 258fdcf121
Status: Passed Duration: 03:17 💡
Started: Nov 7, 2023 11:38 AM Ended: Nov 7, 2023 11:41 AM

Review all test suite changes for PR #6559 ↗︎

@nihal467
Copy link
Member

nihal467 commented Nov 7, 2023

LGTM

@khavinshankar khavinshankar merged commit 60278f9 into develop Nov 7, 2023
36 checks passed
@khavinshankar khavinshankar deleted the rithviknishad/fix-6504 branch November 7, 2023 12:02
Copy link

github-actions bot commented Nov 7, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User signout flow is mafunctioning
3 participants