Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing Cypress POM Conversion | Create New User & Verify its reflection along with validation | User Tab #6514

Merged
merged 8 commits into from
Oct 30, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Oct 29, 2023

WHAT

🤖 Generated by Copilot at 97616cf

This pull request adds and updates end-to-end tests and page objects for the user management features, such as user homepage, user creation, and user view. It also adds id attributes to some UI elements to facilitate testing. It deletes an obsolete test file cypress/e2e/users_spec/user_crud.cy.ts.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 97616cf

  • Add end-to-end tests for user creation feature (link, link, link)
  • Add end-to-end tests for user homepage functionality (link, link, link, link, link)
  • Add an id attribute to the user username div element in the FacilityUsers component (link)
  • Add a method to the FacilityPage class that clicks on the view users option in the manage facility dropdown (link)
  • Delete the file user_crud.cy.ts (link)

@nihal467 nihal467 requested a review from a team October 29, 2023 14:35
@nihal467 nihal467 requested a review from a team as a code owner October 29, 2023 14:35
@nihal467 nihal467 requested a review from vigneshhari October 29, 2023 14:35
@netlify
Copy link

netlify bot commented Oct 29, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c93a36a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/653f7533aeb4b50008484c8b
😎 Deploy Preview https://deploy-preview-6514--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 9:20am

@cypress
Copy link

cypress bot commented Oct 29, 2023

Passing run #1498 ↗︎

0 80 0 0 Flakiness 0

Details:

Existing Cypress POM Conversion | Create New User & Verify its reflection along ...
Project: CARE Commit: c93a36ad16
Status: Passed Duration: 03:25 💡
Started: Oct 30, 2023 9:24 AM Ended: Oct 30, 2023 9:27 AM

Review all test suite changes for PR #6514 ↗︎

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 30, 2023
@github-actions
Copy link

👋 Hi, @nihal467,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 30, 2023
@khavinshankar khavinshankar merged commit 9005adf into develop Oct 30, 2023
30 checks passed
@khavinshankar khavinshankar deleted the user-creation branch October 30, 2023 09:31
@github-actions
Copy link

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants