Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Material UI components in src/Components/ExternalResult/ResultList.tsx: Fixes #4940 #5538

Merged
merged 5 commits into from
May 30, 2023
Merged

Replace Material UI components in src/Components/ExternalResult/ResultList.tsx: Fixes #4940 #5538

merged 5 commits into from
May 30, 2023

Conversation

JahnabDutta
Copy link
Contributor

WHAT

Replacing of the Material UI button present in src/Components/ExternalResult/ResultList.tsx with the Care component ButtonV2. Also change PageTitle to Page.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

  • Import ButtonV2 from src/Common/Components/ButtonV2
  • Replace with material-ui button
  • Import Page from src/Common/Components/Page
  • Wrap the entire div with Page.
  • Remove PageTitle.

@JahnabDutta JahnabDutta requested a review from a team May 26, 2023 10:14
@JahnabDutta JahnabDutta requested a review from a team as a code owner May 26, 2023 10:14
@JahnabDutta JahnabDutta requested a review from gigincg May 26, 2023 10:14
@netlify
Copy link

netlify bot commented May 26, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 0657d09
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6475c0885f65b10008aaba32
😎 Deploy Preview https://deploy-preview-5538--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rithviknishad
rithviknishad approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @JahnabDutta 🚀

@vercel
Copy link

vercel bot commented May 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 9:24am

@nihal467
Copy link
Member

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@khavinshankar khavinshankar merged commit 689e14b into ohcnetwork:develop May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/ExternalResult/ResultList.tsx:
4 participants
@JahnabDutta @nihal467 @rithviknishad @khavinshankar