Add CodeRabbit Suggestions

ohcnetwork · Jan 11, 2025 · aefaf37 · aefaf37
1 parent d529316
commit aefaf37
Showing 1 changed file with 15 additions and 1 deletion.
diff --git a/vite.config.mts b/vite.config.mts
@@ -72,11 +72,20 @@ interface ParsedRemoteConfig {
 }
 
 function parseRemoteConfig(appConfig: string): ParsedRemoteConfig {
+  if (!appConfig.includes("/")) {
+    throw new Error(
+      `Invalid app configuration format: ${appConfig}. Expected 'org/repo' or 'org/repo@url'.`,
+    );
+  }
   // Handle custom URLs (both localhost and custom hosted)
   if (appConfig.includes("@")) {
     const [package_, url] = appConfig.split("@");
     const [org, repo] = package_.split("/");
-
+    if (!org || !repo || !url) {
+      throw new Error(
+        `Invalid custom URL configuration: ${appConfig}. Expected 'org/repo@url'.`,
+      );
+    }
     // Add appropriate protocol based on whether it's localhost
     const protocol = url.includes("localhost") ? "http://" : "https://";
     const fullUrl = url.startsWith("http") ? url : `${protocol}${url}`;
@@ -90,6 +99,11 @@ function parseRemoteConfig(appConfig: string): ParsedRemoteConfig {
 
   // Handle GitHub Pages URLs
   const [org, repo] = appConfig.split("/");
+  if (!org || !repo) {
+    throw new Error(
+      `Invalid GitHub Pages configuration: ${appConfig}. Expected 'org/repo'.`,
+    );
+  }
   return {
     url: `https://${org}.github.io/${repo}/assets/remoteEntry.js`,
     org,