Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Facility Hubs #2135
Added Facility Hubs #2135
Changes from all commits
7753fb6
5f195c6
f22e282
51dcba7
51951da
a91e5f9
84f5d1b
51540d5
61c9f5d
5ed524b
e89629e
06793dd
36a5f88
356f489
574744a
cc35a41
c1fcf89
5ae8602
c306672
c69567b
ea99f89
71a792b
a90da6f
10328ff
063b197
f506f46
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 218 in care/facility/api/serializers/facility.py
Codecov / codecov/patch
care/facility/api/serializers/facility.py#L218
Check warning on line 223 in care/facility/api/serializers/facility.py
Codecov / codecov/patch
care/facility/api/serializers/facility.py#L223
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ensures bi directional uniqueness, but it does not make sense to have cyclical dependences
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the check is already there in serializers if I am understanding you correctly. I have also added it in the model now. Can you please verify if that is what you meant?
Check warning on line 349 in care/facility/models/facility.py
Codecov / codecov/patch
care/facility/models/facility.py#L349