Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prescription: Titrated drug dose #1692

Merged
merged 31 commits into from
Mar 17, 2024
Merged

Prescription: Titrated drug dose #1692

merged 31 commits into from
Mar 17, 2024

Conversation

GokulramGHV
Copy link
Member

@GokulramGHV GokulramGHV commented Oct 30, 2023 •
edited
Loading

Proposed Changes

  • Added titrated prescription

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@GokulramGHV GokulramGHV changed the title adds titrated prescription Prescription: Titrated drug dose Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.27451% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 62.14%. Comparing base (48f1d89) to head (d7f6824).
Report is 3 commits behind head on master.

Files Patch % Lines
care/facility/api/serializers/prescription.py 82.35% 3 Missing and 3 partials ⚠️
...e/facility/api/serializers/patient_consultation.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1692      +/-   ##
==========================================
+ Coverage   62.08%   62.14%   +0.05%     
==========================================
  Files         221      221              
  Lines       12194    12217      +23     
  Branches     1738     1743       +5     
==========================================
+ Hits         7571     7592      +21     
+ Misses       4318     4317       -1     
- Partials      305      308       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rithviknishad
rithviknishad requested changes Oct 31, 2023
View reviewed changes
care/facility/api/serializers/prescription.py Outdated Show resolved Hide resolved
care/facility/api/serializers/prescription.py Outdated Show resolved Hide resolved
care/facility/api/serializers/prescription.py Outdated Show resolved Hide resolved
care/facility/api/viewsets/prescription.py Outdated Show resolved Hide resolved
care/templates/reports/patient_discharge_summary_pdf.html Outdated Show resolved Hide resolved
care/facility/tests/test_medicine_administrations_api.py Outdated Show resolved Hide resolved
care/facility/tests/test_prescriptions_api.py Outdated Show resolved Hide resolved
@rithviknishad
Copy link
Member

@GokulramGHV ensure your pre-commit hook is working. fix the lint errors. Lint CI is failing.

rithviknishad
rithviknishad approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the discharge summary, everything LGTM. @GokulramGHV

@GokulramGHV GokulramGHV marked this pull request as ready for review November 8, 2023 09:07
@rithviknishad rithviknishad requested a review from sainak November 8, 2023 09:10
@rithviknishad rithviknishad mentioned this pull request Nov 15, 2023
Merged
6 tasks
@rithviknishad
Copy link
Member

Also the tests are failing. could you rebase your migrations?

@nihal467
Copy link
Member

nihal467 commented Dec 26, 2023 •
edited
Loading

image

@GokulramGHV iam unable to load the dummy data to your PR, tried with a new fresh database as well, something is wrong

CC: @sainak

@Ashesh3
Copy link
Member

Ashesh3 commented Dec 26, 2023

image @GokulramGHV iam unable to load the dummy data to your PR, tried with a new fresh database as well, something is wrong

CC: @sainak

django.core.exceptions.FieldDoesNotExist: Prescription has no field named 'dosage'
Seems like the dosage was renamed to base_dosage. Update dummy data fixture facility.json accordingly.

@GokulramGHV
Copy link
Member Author

@Ashesh3 thanks, I'll update it

@GokulramGHV
Copy link
Member Author

@nihal467 Please check now

@nihal467
Copy link
Member

LGTM

@rithviknishad rithviknishad marked this pull request as draft February 26, 2024 04:17
@rithviknishad rithviknishad marked this pull request as ready for review February 26, 2024 04:27
@rithviknishad rithviknishad requested a review from sainak February 26, 2024 04:27
@vigneshhari vigneshhari merged commit 5545aa4 into ohcnetwork:develop Mar 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainak sainak sainak approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@vigneshhari vigneshhari vigneshhari approved these changes

Assignees

@rithviknishad rithviknishad

Labels
waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prescription Serializer: serialize last administration record instead of last administered date
7 participants
@GokulramGHV @rithviknishad @sainak @nihal467 @Ashesh3 @vigneshhari @khavinshankar