Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update city_schema.json #220

Closed
wants to merge 7 commits into from

Conversation

hbruch
Copy link
Contributor

@hbruch hbruch commented Dec 19, 2020

This PR fixes #219 by updating city_schema.json.

Note that nevertheless, some current city responses are not valid according to this schema.

Especially Aarhus and Koeln currently report states as "unknown", which IMHO should be reported as "nodata". Further, Koeln reports free=-1 for some parkings. As this seems to represent an unknown value. If true, it should rather be left out, as it is not mandatory.

Note further, that this schema uses some anyOf-type-validations, to allow currently used practice to specify null values for values required by the former schema, but apparently unknown. IMHO null should not be allowed for required properties, but that would result in rework for some data providers.

Finally, this schema s rather strict by not allowing additionalProperties. This kind of blocks experimental features, but uncovers properties not yet specified in the schema. Probably, additionalProperties should better be set to true.

@hbruch
Copy link
Contributor Author

hbruch commented Dec 21, 2020

Looks like the latest feedparser makes use of python 3.6 string formatting syntax (f'), which fails the build. I guess that either feedparser version should be frozen at an earlier version in requirements.txt or minimum compatibility raised to 3.6.

@jklmnn
Copy link
Member

jklmnn commented Dec 22, 2020

Looks like the latest feedparser makes use of python 3.6 string formatting syntax (f'), which fails the build. I guess that either feedparser version should be frozen at an earlier version in requirements.txt or minimum compatibility raised to 3.6.

Thanks for looking at this issue. I think we can safely drop Python 3.5 since even Debian Stable (which we use) has already Python 3.7. (see #222). Do you have any requirement in this regard? If you need Python 3.6 I would still include it otherwise I'd make Python 3.7 the minimum version.

schema/city_schema.json Outdated Show resolved Hide resolved
@hbruch
Copy link
Contributor Author

hbruch commented Dec 22, 2020

No objections to moving to python 3.7 as minimum requirement. I'll open an issue to gather what needs to be done.

@hbruch
Copy link
Contributor Author

hbruch commented Jan 6, 2021

I resolved the state related change requests, switched additonalProperties to true, to allow custom extensions and updated the README.md example to reflect the schema.

@hbruch hbruch requested a review from jklmnn January 6, 2021 12:04
@jklmnn
Copy link
Member

jklmnn commented Jan 6, 2021

Fixed by 3f2eb37.

@jklmnn jklmnn closed this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

city_schema.json outdated(?)
2 participants