[IMP] util/modules: force install of new modules #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jjmaksoud
force-pushed
the
master-force-install-new-modules-maji
branch
from
bce810b to
a312606
Compare
|
upgradeci retry with always only base |
KangOl
requested changes
Sep 24, 2024
KangOl
reviewed
Sep 24, 2024
jjmaksoud
force-pushed
the
master-force-install-new-modules-maji
branch
from
a312606 to
3fbd00d
Compare
KangOl
reviewed
Sep 25, 2024
KangOl
reviewed
Sep 25, 2024
jjmaksoud
force-pushed
the
master-force-install-new-modules-maji
branch
4 times, most recently
from
ef5d719 to
d536368
Compare
KangOl
requested changes
Sep 26, 2024
The method 'force_install_module' only works when the module already exists in the database and changes its state immediately. For new modules this does not work unless the module is explicitly added, or we use the auto discovery methods instead.
jjmaksoud
force-pushed
the
master-force-install-new-modules-maji
branch
from
d536368 to
03c9ff4
Compare
KangOl
approved these changes
Sep 26, 2024
|
@robodoo r- On hold until some retro-compatibility questions are sorted out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
force_install_moduleonly works when the module already exists in the database and changes its state immediately. For new modules this does not work unless the module is explicitly added, or we use the auto discovery methods instead.A check
_assert_modules_existsis also added to the force installation.As a solution, the check for version is added to see if we can delay the force installation to
post-basewhen the module is auto discovered, and the implementation is moved to_force_install_module. The calls forforce_install_moduleare replaced in the following methods where the module is expected to exist:merge_modulenew_module_deptrigger_auto_install_trigger_auto_discovery