[IMP] runbot: add support for attributes on md url #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williambraecky
force-pushed
the
18.0-md-link-attributes-wbr
branch
2 times, most recently
from
e46db93 to
f866777
Compare
d-fence
reviewed
Jan 15, 2025
runbot/tests/test_utils.py
Outdated
| ) | ||
|
|
||
| # Invalid input | ||
| with mute_logger('odoo.addons.runbot.common'): |
There was a problem hiding this comment.
Suggested change
| with mute_logger('odoo.addons.runbot.common'): | |
| with self.assertLogs(level='WARNING'): |
while at it, why not assert that the warning was triggered
Adds support for attributes on our markdown implementation, mainly to add support for target="_blank" on urls. This can be used to change the behavior of links when we want to differentiate between navigation and information.
Williambraecky
force-pushed
the
18.0-md-link-attributes-wbr
branch
from
f866777 to
dd988e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for attributes on our markdown implementation, mainly to add support for target="_blank" on urls.
This can be used to change the behavior of links when we want to differentiate between navigation and information.