Better domains - autocompletion, diagnostics, hover #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on models, get_symbols returns all symbols that build the model, but there was no easy way to get all symbols that build the model with inherited models. get_full_model_symbols do it now. It doesn't contain inheritS howevers.
Add return values for with_company, with_context, with_prefetch, with_user, with_env, exists
fda-odoo
force-pushed
the
master-domains-auto-fda
branch
from
02e2c6c to
1cb2e18
Compare
mmahrouss
approved these changes
Jan 9, 2025
| let from_module = file.borrow().find_module().clone(); | ||
| Symbol::all_members(&parent, session, &mut all_symbols, true, from_module, &mut None, false); | ||
| for (_symbol_name, symbols) in all_symbols { | ||
| //we could use symbol_name to remove duplicated names, but it would hide functions vs variables |
There was a problem hiding this comment.
But we cannot have functions and variables with the same name, can we?
There was a problem hiding this comment.
We could. Some would be shadowed, but as we are searching here in classes, inheritance, co-models,... we could find different symbols type with the same name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR contains all changes and fixs about search domains.