Add "Save Snippet" sidebar button + display custom inner content in the sidebar #3952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
sobo-odoo
force-pushed
the
master-mysterious-egg-sobo-2
branch
from
21a0353 to
b2480c8
Compare
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
FrancoisGe
reviewed
Jan 16, 2025
addons/html_builder/static/src/builder/builder_sidebar/tabs/block_tab/block_tab.js
Show resolved
Hide resolved
| expect(saveButtonSelector).toHaveCount(1); | ||
|
|
||
| // TODO improve when "request_save" will be done. | ||
| // Maybe make a tour to test the behavior ? |
addons/html_builder/static/src/builder/builder_sidebar/builder_sidebar.js
Show resolved
Hide resolved
addons/html_builder/static/src/builder/builder_sidebar/builder_sidebar.js
Show resolved
Hide resolved
| this.context["model"] = editableParentEl.dataset.oeModel; | ||
| this.context["field"] = editableParentEl.dataset.oeField; | ||
| this.context["resId"] = editableParentEl.dataset.oeId; | ||
| await rpc("/web/dataset/call_kw/ir.ui.view/save_snippet", { |
There was a problem hiding this comment.
why not use orm.call like delete_snippet ?
| context: this.context, | ||
| }, | ||
| }); | ||
| resolve(); |
There was a problem hiding this comment.
add new customSnippet to snippetsByCategory.snippet_custom. It will trigger the reactivity. We probably not need to reload the page
addons/html_builder/static/src/builder/builder_sidebar/tabs/block_tab/block_tab.xml
Show resolved
Hide resolved
addons/html_builder/static/src/builder/builder_sidebar/tabs/block_tab/block_tab.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.