-
Notifications
You must be signed in to change notification settings - Fork 33
Add JBoss EAP XP 2.0 #67
base: master
Are you sure you want to change the base?
Conversation
ehsavoie
commented
Jan 13, 2021
- for full provisionned server
- for bootable jar
targetPort: 16686 | ||
- name: eap-xp | ||
container: | ||
image: registry.redhat.io/ubi8/openjdk-11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a problem :-(
Devfiles in default odo registry (this registry) should work on vanilla Kubernetes. This image is sadly not accessible without Red Hat loggin :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be replaced by registry.access.redhat.com/ubi8/openjdk-11
that does not require authentication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubi should be available without authentication
https://catalog.redhat.com/software/containers/ubi8/openjdk-11/5dd6a4b45a13461646f677f4?container-tabs=gti>i-tabs=unauthenticated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ubi should be available without authentication
https://catalog.redhat.com/software/containers/ubi8/openjdk-11/5dd6a4b45a13461646f677f4?container-tabs=gti>i-tabs=unauthenticated
Yes, but with one difference. It needs to be downloaded as registry.access.redhat.com/ubi8/openjdk-11
Using it from registry.redhat.io/ubi8/openjdk-11
will still require login.
components: | ||
- name: eap-xp | ||
container: | ||
image: registry.redhat.io/jboss-eap-7/eap-xp2-openjdk11-openshift-rhel8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly as in previous Devfile, people without Red Hat account won't be able to download this image :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can only for now put wildfly examples and not EAP in the public catalog ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but thinking about it - it won't be unusal to have images in private/secured repos - what is the worfklow users would do to use these ? do a docker login
or similar before running ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxandersen I think so (according to this https://kubernetes.io/fr/docs/tasks/configure-pod-container/pull-image-private-registry/) , the image is only used on the cluster so they would have to grant access to the image registry on their kubernetes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but thinking about it - it won't be unusal to have images in private/secured repos - what is the worfklow users would do to use these ? do a docker login or similar before running ?
Yes, as @ehsavoie pointed out users will have to make sure that the cluster uses the right ImagePullSecret.
For registry.redhat.io on OCP no extra step should be required as they already have this setup. But for Kubernetes, it requires extra steps.
We are trying to target all Kubernetes users, not just OpenShift, that is why we don't want to mix Red Hat only Devfiles, with upstream Devfiles in odo's default public devfile registry.
We are currently trying to find how to properly handle that so it doesn't create unnecessary complications for users.
* for full provisionned server * for bootable jar