Skip to content
This repository has been archived by the owner on May 11, 2021. It is now read-only.

Add JBoss EAP XP 2.0 #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ehsavoie
Copy link

  • for full provisionned server
  • for bootable jar

targetPort: 16686
- name: eap-xp
container:
image: registry.redhat.io/ubi8/openjdk-11
Copy link
Collaborator

@kadel kadel Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a problem :-(
Devfiles in default odo registry (this registry) should work on vanilla Kubernetes. This image is sadly not accessible without Red Hat loggin :-(

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be replaced by registry.access.redhat.com/ubi8/openjdk-11 that does not require authentication

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubi should be available without authentication
https://catalog.redhat.com/software/containers/ubi8/openjdk-11/5dd6a4b45a13461646f677f4?container-tabs=gti&gti-tabs=unauthenticated

Yes, but with one difference. It needs to be downloaded as registry.access.redhat.com/ubi8/openjdk-11
Using it from registry.redhat.io/ubi8/openjdk-11 will still require login.

components:
- name: eap-xp
container:
image: registry.redhat.io/jboss-eap-7/eap-xp2-openjdk11-openshift-rhel8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly as in previous Devfile, people without Red Hat account won't be able to download this image :-(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can only for now put wildfly examples and not EAP in the public catalog ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but thinking about it - it won't be unusal to have images in private/secured repos - what is the worfklow users would do to use these ? do a docker login or similar before running ?

Copy link
Author

@ehsavoie ehsavoie Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxandersen I think so (according to this https://kubernetes.io/fr/docs/tasks/configure-pod-container/pull-image-private-registry/) , the image is only used on the cluster so they would have to grant access to the image registry on their kubernetes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but thinking about it - it won't be unusal to have images in private/secured repos - what is the worfklow users would do to use these ? do a docker login or similar before running ?

Yes, as @ehsavoie pointed out users will have to make sure that the cluster uses the right ImagePullSecret.
For registry.redhat.io on OCP no extra step should be required as they already have this setup. But for Kubernetes, it requires extra steps.

We are trying to target all Kubernetes users, not just OpenShift, that is why we don't want to mix Red Hat only Devfiles, with upstream Devfiles in odo's default public devfile registry.

We are currently trying to find how to properly handle that so it doesn't create unnecessary complications for users.

 * for full provisionned server
 * for bootable jar
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants