Windows prereqs tests #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking the result for the Docker backend requires asynchronous calls to Docker.
With the Docker backend on Windows, it's easier to store logs in a location where they're not moved, as a directory cannot be renamed if it contains open file descriptors. For the btrfs and zfs backends, the original location is retained.
MisterDA
force-pushed
the
windows-prereqs-tests
branch
from
95c70ad to
9d54b0c
Compare
tmcgilchrist
approved these changes
Nov 6, 2022
MisterDA
force-pushed
the
windows-prereqs-tests
branch
2 times, most recently
from
ed2eecc to
fe61b76
Compare
MisterDA
force-pushed
the
windows-prereqs-tests
branch
from
5b3c9b4 to
e841030
Compare
tmcgilchrist
approved these changes
Nov 7, 2022
tmcgilchrist
added a commit
to tmcgilchrist/opam-repository
that referenced
this pull request
Nov 7, 2022
CHANGES: - Add --fuse-path to allow selection of the path redirected by FUSE (@mtelvers ocurrent/obuilder#128, reviewed by @MisterDA ) - Pre-requisites for Windows support using docker for Windows (@MisterDA ocurrent/obuilder#116, reviewed by @tmcgilchrist) - Additional tests and prerequistes for Windows support (@MisterDA ocurrent/obuilder#130, reviewed by @tmcgilchrist) - Add support for Docker/Windows spec (@MisterDA ocurrent/obuilder#117, reviewed by @tmcgilchrist) - Depend on Lwt.5.6.1 for bugfixes (@MisterDA ocurrent/obuilder#108, reviewed by @tmcgilchrist) - Add macOS support (@patricoferris ocurrent/obuilder#87, reviewed by @tmcgilchrist @talex5 @kit-ty-kate) - Enable macOS tests only on macOS (@MisterDA ocurrent/obuilder#126, reviewed by @tmcgilchrist) - Dune 3.0 generates empty intf for executables (@MisterDA ocurrent/obuilder#111, reviewed by @talex5) - Fix warnings and CI failure (@MisterDA ocurrent/obuilder#110, reviewed by @talex5) - Expose store root and cmdliner term with non-required store (@MisterDA ocurrent/obuilder#119, reviewed by @tmcgilchrist) - Expose Rsync_store module (@MisterDA ocurrent/obuilder#114, reviewed by @talex5) - Rsync hard-links to save space (@art-w ocurrent/obuilder#102, reviewed by @patricoferris)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting tests require changing the root from
/toC:/, the default shell tocmd /S /C, and mocking commands withoutsudo.The store result need access to Docker, so as it requires an asynchronous call it has to be wrapped in a Lwt promise.
The log file has to be moved to a static location because of #118. There is still one test that fails, but it is difficult to debug.
Running tests has revealed that they might hang if an error occurs, and they won't necessarily reveal the error. Adding a fixed timeout of 10s helps by not letting the CI run for hours.