protocols Solaris compilation fixes #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled Solaris plugins for kstat
kstat_value_to_string returns the value of a kstat in char format. It is useful when we want all the values and don't necessarily know the name of the field (similar to a dump). The stats are returned in 2 char arrays, one for the names of the stats and one for their respective values.
octo
pushed a commit
that referenced
this pull request
Aug 11, 2016
The old way of detecting libpython was unreliable and did not work on OS X. Instead use python-config which was introduced in python 2.6. For older versions of python you can still set PYTHON_CPPFLAGS and PYTHON_LDFLAGS on the ./configure command line. By default we look for python3-config, python2-config and last python-config. The path to python-config can be overriden by setting PYTHON_CONFIG. Fixes collectd#888 and #27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have fixed the compilation problems on Solaris. Also, I have added a function called get_kstat_value_to_string which essentially dumps kstat name/value pairs. I used it in the protocols module to called all possible stat/value pairs.
Regards,
Cosmin Ioiart