Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dawn WGPU String usage. #8083

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nchavez324
Copy link

Fix issues/8082 where using Dawn with the WGPU backend at head causes compilation and runtime issues. See issue for details on compiler and debugger output.

@ocornut
Copy link
Owner

ocornut commented Oct 21, 2024

Hello,
Thanks for the PR. Are you sure that the 3 additions that are not under ifdef will work under the 2 other implementation? (Emscripten, Dawn, WebGPU)
Thank you.

@nchavez324
Copy link
Author

Hey Omar, thanks for taking a look. Yeah, the other implementations are still using const char *:

@ocornut
Copy link
Owner

ocornut commented Oct 21, 2024

Hello, i believe you may misread my question. I am talking about the other changes.

@nchavez324
Copy link
Author

Ah sorry about that; yes, my mistake I missed that; updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dawn WebGPU Strings
2 participants