Fix: correctly escapes double quotes when converting ux.table to csv #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify replace with replaceAll as mentioned in this issue : oclif#944 (comment)
|
Thanks for the contribution! Before we can merge this, we need @julesbonnard to sign the Salesforce Inc. Contributor License Agreement. |
mdonnalley
requested changes
Feb 29, 2024
There was a problem hiding this comment.
Code change looks good but can you add a test case here: https://github.com/oclif/core/blob/main/test/cli-ux/styled/table.test.ts#L150
Thanks!
|
Thanks for your review, I've just added a new test case. I have one more question for the future: should the check for escaping quotes be done line by line (as it is now) or value by value? The latter would produce slightly cleaner CSVs, but at some performance cost. |
mdonnalley
approved these changes
Mar 1, 2024
mdonnalley
added a commit
that referenced
this pull request
Mar 1, 2024
…977) (#980) * Fix: correctly escapes double quotes when converting ux.table to csv modify replace with replaceAll as mentioned in this issue : #944 (comment) * test: complete ux.table test to check if double quotes escaping is correct Co-authored-by: Jules Bonnard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modify replace with replaceAll as mentioned in this issue : #944 (comment)