Add matching based on platform.features and platform.compatibilities #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is a simple prototype to show how we could improve image selection in containerd.
The code of this prototype should be improved and maybe platforms in a few places refactored, however, it solves the problem and shows the general idea which is:
platform.features
for CPU featuresplatform.compatibilities
which is a map that allows to provide matching labels.Additionally, I introduced a new config file
/etc/containerd/platform-config.toml
where people can provide information to containerd services about nodes cpu features and compatibility data.Example of the new config file: