Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve quick peek with highlighting in both the jump and holes commands #1705

Merged
merged 24 commits into from
Jan 17, 2025

Conversation

PizieDust
Copy link
Contributor

@PizieDust PizieDust commented Jan 7, 2025

This PR

  • fixes the empty list bug (displays a message rather than an empty quick pick)
  • allows the user to preview the different jump targets using the arrow keys without jumping to them.

Match first word from position of interest

jump_highlight_5.mp4

cc @voodoos @awilliambauer

@PizieDust PizieDust marked this pull request as draft January 7, 2025 14:14
@PizieDust PizieDust marked this pull request as ready for review January 9, 2025 12:17

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • src-bindings/vscode/vscode.ml: Language not supported
  • src-bindings/vscode/vscode.mli: Language not supported
  • src/extension_commands.ml: Language not supported
src/extension_commands.ml Outdated Show resolved Hide resolved
src/extension_commands.ml Outdated Show resolved Hide resolved
Copy link
Contributor

@xvw xvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nitpick. Feel free to discard it!

@PizieDust
Copy link
Contributor Author

Just a small nitpick. Feel free to discard it!

It's done in the latest commit :)

src/extension_commands.ml Outdated Show resolved Hide resolved
src/extension_commands.ml Outdated Show resolved Hide resolved
src/extension_commands.ml Outdated Show resolved Hide resolved
src/extension_commands.ml Outdated Show resolved Hide resolved
src/extension_commands.ml Show resolved Hide resolved
src/extension_commands.ml Outdated Show resolved Hide resolved
src/import.ml Outdated Show resolved Hide resolved
src/extension_commands.ml Outdated Show resolved Hide resolved
src/extension_commands.ml Outdated Show resolved Hide resolved
src/extension_commands.ml Outdated Show resolved Hide resolved
src/extension_commands.ml Outdated Show resolved Hide resolved
@PizieDust PizieDust requested a review from voodoos January 16, 2025 10:22
@voodoos voodoos changed the title Jump changes Improve quick peek with highlighting in both the jump and holes commands Jan 17, 2025
@voodoos voodoos merged commit bfa5e0e into ocamllabs:master Jan 17, 2025
7 checks passed
@PizieDust PizieDust deleted the jump_changes branch January 17, 2025 11:55
@smorimoto smorimoto added type: bug Something isn't working type: improvement labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants