Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE pds and hll #27268

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

UPDATE pds and hll #27268

wants to merge 1 commit into from

Conversation

orbitz
Copy link

@orbitz orbitz commented Jan 14, 2025

No description provided.

packages/pds/pds.5.41/opam Outdated Show resolved Hide resolved
packages/hll/hll.4.2/opam Outdated Show resolved Hide resolved
@mseri
Copy link
Member

mseri commented Jan 15, 2025

There are many lower bound failures, can you have a look at what is needed for the package to build correctly? My impression is that containers and cmdliner need a lower bound, toml needs a different lower bound and maybe ocaml itself needs a lower bound

@orbitz
Copy link
Author

orbitz commented Jan 16, 2025

Thanks @mseri , I think the biggest issue is toml, I'll get that fixed.

@mseri
Copy link
Member

mseri commented Jan 21, 2025

You need a lower bound on ocaml >= 4.08, one on cmdliner (I think >= 1.1.0) and ine in cintainers (nit sure which version)

@orbitz orbitz force-pushed the update-pds-and-hll branch 4 times, most recently from 4d0bfb7 to 78b85bf Compare January 22, 2025 19:52
@orbitz
Copy link
Author

orbitz commented Jan 23, 2025

@mseri I think we're finally down to errors not caused by me! Looks like there was a network error in fetching the code on this. I'm also not sure if the experimental builds are required to succeees?

Comment on lines +31 to +33
description: """
Create opam package files from a repository.
"""
Copy link
Member

@mseri mseri Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: """
Create opam package files from a repository.
"""
synopsis: "Create opam package files from a repository."
license: "BSD-3-Clause"

Comment on lines +32 to +34
description: """
A tool to build Makefiles for Ocaml projects.
"""
Copy link
Member

@mseri mseri Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: """
A tool to build Makefiles for Ocaml projects.
"""
synopsis: "A tool to build Makefiles for Ocaml projects."
license: "BSD-3-Clause"

@mseri
Copy link
Member

mseri commented Jan 23, 2025

Almost ready. The experimental builds are not a blocker.
But the opam file needs a slight update:

    Error in pds.5.42: warning 68: Missing field 'license'
    Error in pds.5.42: error 57: Synopsis must not be empty
    Error in hll.4.3: warning 68: Missing field 'license'
    Error in hll.4.3: error 57: Synopsis must not be empty

Could you check my suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants