[3.17] backport #11253: fix(melange): disallow private implementations of public virtual libs… #11372
+48
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiste
reviewed
Jan 22, 2025
…ocaml#11253) * test(melange): show wrong require for private impl of public virtual lib Signed-off-by: Antonio Nuno Monteiro <[email protected]> * fix(melange): disallow private implementations of public virtual libs Signed-off-by: Antonio Nuno Monteiro <[email protected]> * changelog Signed-off-by: Antonio Nuno Monteiro <[email protected]> --------- Signed-off-by: Antonio Nuno Monteiro <[email protected]>
anmonteiro
force-pushed
the
anmonteiro/backport-11253
branch
from
0851aca to
88dec81
Compare
|
@maiste thanks for catchig, just fixed compilation and rebased against the base branch. |
|
Thanks for the fix, as soon as the CI goes green (for the parts that are supposed to), I'll merge this and start the release on Opam 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.