Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.17]backport #11248 fix(melange): use output of virtual library when compiling its source… #11371

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

anmonteiro
Copy link
Collaborator

No description provided.

…ocaml#11248)

* test(melange): show crash when depending on public virtual lib impl

Signed-off-by: Antonio Nuno Monteiro <[email protected]>

* fix(melange): use output of virtual library when compiling its source
modules

Signed-off-by: Antonio Nuno Monteiro <[email protected]>

* chore: add changelog entry

Signed-off-by: Antonio Nuno Monteiro <[email protected]>

---------

Signed-off-by: Antonio Nuno Monteiro <[email protected]>
@anmonteiro anmonteiro changed the title backport #11248 fix(melange): use output of virtual library when compiling its source… [3.17]backport #11248 fix(melange): use output of virtual library when compiling its source… Jan 22, 2025
@maiste maiste added the release PR or issue for releasing a new dune version label Jan 22, 2025
@maiste maiste merged commit 730dc7d into ocaml:3.17 Jan 23, 2025
27 of 29 checks passed
@maiste maiste mentioned this pull request Jan 21, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release PR or issue for releasing a new dune version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants