Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dune subst test for directory containing just a .opam file #11291

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mtelvers
Copy link

@mtelvers mtelvers commented Jan 14, 2025

PR supporting #11290

@mtelvers mtelvers changed the title Issue 11290 dune subst test for directory containing just a .opam file Jan 14, 2025
@mtelvers mtelvers force-pushed the dune-sub-issue branch 3 times, most recently from a35026c to fbc4a1f Compare January 14, 2025 13:39
@Leonidas-from-XIV
Copy link
Collaborator

Can you make the tests succeed in CI? It's ok to add error output as long as it is reproducible.

(If you rebase the 5.3.0 CI failure should resolve itself, we updated the GH action since)

@mtelvers
Copy link
Author

I have rebased this PR. I am working around the issue in OCaml-CI by adding this line to the build. However, it isn't perfect as, it sometimes creates a dune-project file where there wasn't one previously.

echo '(lang dune 3.0)' > './dune-project'

The error which I see is this:

#=== ERROR while compiling current.dev ========================================#
# context     2.3.0 | linux/arm64 | ocaml-base-compiler.4.14.2 | pinned(file:///src/ocurrent)
# path        ~/.opam/4.14/.opam-switch/build/current.dev
# command     ~/.opam/4.14/bin/dune subst
# exit-code   1
# env-file    ~/.opam/log/current-1-e2b7be.env
# output-file ~/.opam/log/current-1-e2b7be.out
### output ###
# File ".", line 1, characters 0-0:
# Error: There is no dune-project file in the current directory, please add one
# with a (name <name>) field in it.
# Hint: 'dune subst' must be executed from the root of the project.

The full log is here

mtelvers and others added 2 commits January 22, 2025 17:17
Signed-off-by: Mark Elvers <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants