Enable preview feature to allow global filter to be at the end. #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dev setup to contributing Add tags as a property of task Add query by tag in query language Add sort by tag Added unit tests for coverage
Implement feedback on filter and tag sorting, ready for next release obsidian-tasks-group#632
docs: add documentation on tag sorting fix: handle lack of tag in the comparison for tag sorting test: add increased test coverage to tags
A task with a character between the square brackets should be marked as checked and have the is-checked class on the parent LI
Allows optional or features in development to be enabled conditionally, there is a second commit coming to move the new functionality under the relevant flags which will make the PR review and check in simpler as code can go in but not be used until the flag is set.
13 tasks
claremacrae
added
the
scope: tags
|
I'm trying to get the list of PRs down to ones that are feasibly likely to merge, with the goal of merging the ones that still compatible enough with the current code that I can make them mergeable. I've done a quick review of this one, even though it is still Draft. It contains changes unrelated to the description, and moves some files to different locations (making them no possible to compare against the previous version in the GitHub website). So sorry but merging this is not realistic and I'm closing it. Future options include:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This resolves #147, An option to always store the global filter at the end of the description would ensure that tasks are compatible with the day planner plugin.
It also would allow #462 to be abandoned as it is getting no response.
This is based off the branch from #670 so you will see additional changes that will go when that is merged.
This PR moves the global filter out of the description completely and will prepend or append it when serializing the task to a markdown string. This is handled in the Task object and in the Task edit UI.
It is under a new feature flag so code will only be called when that is enabled. The flag is not marked as stable until we get user feedback and then an additional PR can be made to enable it as a regular setting.
Motivation and Context
See the following discussions, PRs and Issues.
How has this been tested?
Added updated tests to the toString method of the Tasks object.
Screenshots (if appropriate):
NA
Types of changes
Checklist:
yarn run lint.By creating a Pull Request you agree to our Code of Conduct. For further guidance on contributing please see contributing guide