fix: Handle Enter key event for IME inputs

[ryotatake]

Types of changes

• Bug fix (prefix: fix - non-breaking change which fixes an issue)
  • Issue/discussion: shortcuts enter in task dialog conflicts with IME inputs for CJK #2214

Description

“Create or edit Task" Modal input, there was a conflict between the Enter key event used to confirm IME conversions and the Enter key event used to create tasks, causing unintended behavior.

This has been corrected so that the Enter key is not used to create a task when the IME conversion is confirmed.

Motivation and Context

How has this been tested?

Manually tested the following

• When using IME, the task is not created when the conversion is confirmed with the Enter key. When the Enter key is pressed again, the task is created.
• When IME is not used, the task is created when the Enter key is pressed.

Screenshots (if appropriate)

before fix

IME_input.mov

after fix

IME_input_after_fix.mov

Checklist

• My code follows the code style of this project and passes yarn run lint.
• [-] My change requires a change to the documentation.
• [-] I have updated the documentation accordingly.
• My change has adequate Unit Test coverage.
  • I was not sure if testing was needed for this change, so please let me know if it is needed.

Terms

• My contribution follows this project's contributing guide
• I agree to follow this project's Code of Conduct

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[claremacrae]

For my own reference, this is the documentation of the code added e.isComposing

https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/isComposing

[claremacrae]

Thank you very much for doing this - I would have had no idea this was the solution.

I looked for other uses of the same pattern elsewhere in Tasks, and found these:

obsidian-tasks/src/Suggestor/EditorSuggestorPopup.ts

Lines 107 to 116 in d26fd2e

	if (value.suggestionType === 'empty') {
	// Close the suggestion dialog and simulate an Enter press to the editor
	this.close();
	const eventClone = new KeyboardEvent('keydown', {
	code: 'Enter',
	key: 'Enter',
	});
	(editor as any)?.cm?.contentDOM?.dispatchEvent(eventClone);
	return;
	}

obsidian-tasks/src/ui/Dependency.svelte

Lines 57 to 66 in 4e8c961

	case 'Enter':
	if (searchIndex !== null) {
	e.preventDefault();
	addTask(searchResults[searchIndex]);
	searchIndex = null;
	inputFocused = false;
	} else {
	_onDescriptionKeyDown(e);
	}
	break;

Are they things you would be interested in looking at too?

[claremacrae]

(I've edited the comment about to increase the number of lines of code shown, for readability)