Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove console error when line is deleted by 'Toggle task done' command #3257

Merged
merged 3 commits into from
Dec 31, 2024

Conversation

claremacrae
Copy link
Collaborator

@claremacrae claremacrae commented Dec 31, 2024

Types of changes

Changes visible to users:

Internal changes:

  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

Motivation and Context

Fix a traceback error discovered earlier today:

How has this been tested?

  • Adding failing tests - then fixing them
  • Running existing tests
  • Confirming fix by exploratory testing

Checklist

Terms

@claremacrae claremacrae added the scope: commands Additions and changes to the commands supplied by Tasks label Dec 31, 2024
@claremacrae claremacrae changed the title fix: Remove console error when line deleted by 'Toggle task done' command fix: Remove console error when line is deleted by 'Toggle task done' command Dec 31, 2024
@claremacrae claremacrae merged commit a4cbe90 into main Dec 31, 2024
4 checks passed
@claremacrae claremacrae deleted the fix-issue-3256 branch December 31, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: commands Additions and changes to the commands supplied by Tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console error when 'Toggle task done' command deletes the task line
1 participant