Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Reduce repetition of parsing of show/hide options #3214

Merged
merged 13 commits into from
Dec 1, 2024

Conversation

claremacrae
Copy link
Collaborator

Types of changes

Internal changes:

  • Refactor (prefix: refactor - non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)
  • Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

Refactor to reduce repetition in QueryLayoutOptions and TaskLayoutComponent.

Motivation and Context

To make the code easier to read and to modify.

How has this been tested?

  • Automated tests

Specifically, I added full tests of the existing code first, and then refactored the original code.

I am conscious that there is now some similarity between code in the tests and the implementation - but the tests came first, to ensure I didn't break the code during refactoring.

Screenshots (if appropriate)

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change has adequate Unit Test coverage.

Terms

@claremacrae claremacrae added type: internal Only regards development or contributing scope: show/hide The show and hide instructions in Tasks query blocks labels Dec 1, 2024
Copy link

sonarqubecloud bot commented Dec 1, 2024

@claremacrae claremacrae merged commit 9c73402 into main Dec 1, 2024
3 checks passed
@claremacrae claremacrae deleted the refactor-layout-option-parsing branch December 1, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: show/hide The show and hide instructions in Tasks query blocks type: internal Only regards development or contributing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant