fix: Allow spaces after show and hide - and improve error message
#3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctionLowerAndUpper()
… RegEx This makes parsing of show/hide instructions a little more relaxed, in that multiple spaces after show/hide are now permitted.
claremacrae
added
the
scope: show/hide
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Changes visible to users:
fix- non-breaking change which fixes an issue)Internal changes:
refactor- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test- additions and improvements to unit tests and the smoke tests)Description
Some refactorings of the
Queryclass.Mainly this moves a big switch statement in
parseHideOptions()to functions in the relevant classesQueryLayoutOptionsandTaskLayoutOptions.It ended up with two observable changes to users, hence I am labelling this as a bug fix:
show treeshoworhidethe error message is a bit more specific, and could be extended in future to list the allowed values.Motivation and Context
My original goal was to clean up
Querysomewhat.The main benefit is no longer needing to remember to add new options to
Query.hideOptionsRegexp, which has tripped me up many times.How has this been tested?
Checklist
yarn run lint.Terms