refactor: add a container for FieldLayoutDetails and get data attributes from it
#2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I don't think GitHub lets me know when a PR is marked as ready for review, so do let me know when it is no longer a draft.... |
|
I thought we discussed that we shall work on this PR tomorrow together. Or do you consider this as good enough to merge and wish start a new branch from main tomorrow? Both are fine for me. |
|
Oh sorry yes, I was unclear... This is good enough to merge... A definite improvement |
|
ok great, then I mark this as ready for review |
|
Please check if the new tests are explicit enough |
claremacrae
approved these changes
Nov 20, 2023
claremacrae
added
type: internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a container for
FieldLayoutDetailsand get data attributes from it with a dedicated method.Motivation and Context
Encapsulate data and behaviour in an error-free way.
Prepare for refactoring of the rendering & layout code to make adding new features easier.
How has this been tested?
Unit tests added for the new class.
Types of changes
refactor- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test- additions and improvements to unit tests and the smoke tests)Checklist
yarn run lint.Terms