Skip to content

Commit

Permalink
refactor: . SonarLint fixed two issues in StatusesTestHelpers.ts
Browse files Browse the repository at this point in the history
- Combine imports from same file
- Use forEach() instead of map(), as the result is not used
  • Loading branch information
claremacrae committed Oct 30, 2023
1 parent 724142a commit 834e15f
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions tests/TestingTools/StatusesTestHelpers.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type { StatusCollection } from '../../src/StatusCollection';
import type { StatusCollectionEntry } from '../../src/StatusCollection';
import type { StatusCollection, StatusCollectionEntry } from '../../src/StatusCollection';
import { StatusSettings } from '../../src/Config/StatusSettings';
import { Status } from '../../src/Status';
import { StatusRegistry } from '../../src/StatusRegistry';
Expand All @@ -21,7 +20,7 @@ export function createStatuses(
StatusSettings.replaceStatus(core, core[1], Status.createFromImportedValue(coreStatusesData[1]));

StatusSettings.deleteAllCustomStatuses(statusSettings);
customStatusesData.map((entry: StatusCollectionEntry) => {
customStatusesData.forEach((entry: StatusCollectionEntry) => {
StatusSettings.addStatus(statusSettings.customStatuses, Status.createFromImportedValue(entry));
});

Expand Down

0 comments on commit 834e15f

Please sign in to comment.