Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: OB-36454 update values to new conventions and add and update tests #233

Merged
merged 1 commit into from
Oct 2, 2024
Merged

feat: OB-36454 update values to new conventions and add and update tests #233

merged 1 commit into from
Oct 2, 2024

Conversation

arthur-observe
Copy link
Contributor

  • Update values file to give more descriptive names and add comments for clarity
  • Add new examples for prometheus labels

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

The following chart updates are necessary:

diff --git a/charts/agent/Chart.yaml b/charts/agent/Chart.yaml
index 12fff75..dded4fe 100644
--- a/charts/agent/Chart.yaml
+++ b/charts/agent/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: agent
 description: Chart to install K8s collection stack based on Observe Agent
 type: application
-version: 0.18.0
+version: 0.19.0
 appVersion: "1.1.0"
 dependencies:
   - name: opentelemetry-collector

NathanNam
NathanNam approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@NathanNam NathanNam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arthur-observe arthur-observe changed the title feat: OB-36454 update values to new conventions and add and upate tests feat: OB-36454 update values to new conventions and add and update tests Oct 1, 2024
@arthur-observe arthur-observe force-pushed the arthur/OB-36454-metrics-discovery-values-file-update branch from 3973b86 to d643670 Compare October 1, 2024 23:15
@arthur-observe
feat: OB-36454 update values file to new conventions and add and upda…
ef37a2a 
…te tests

- Update values file to give more descriptive names and add comments for clarity
- Add new examples for prometheus labels
@arthur-observe arthur-observe force-pushed the arthur/OB-36454-metrics-discovery-values-file-update branch from d643670 to ef37a2a Compare October 2, 2024 00:26
@arthur-observe arthur-observe merged commit b0f00b6 into main Oct 2, 2024
11 checks passed
@arthur-observe arthur-observe deleted the arthur/OB-36454-metrics-discovery-values-file-update branch October 2, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanNam NathanNam NathanNam approved these changes

@obs-gh-alexlew obs-gh-alexlew obs-gh-alexlew approved these changes

@xueweiz xueweiz Awaiting requested review from xueweiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arthur-observe @NathanNam @obs-gh-alexlew