-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: reorganize stack subcharts to fix the enable toggle for subcharts (
#13) Helm seems to choke on condition statements in subcharts that themselves have dependencies. Managing the first-level subcharts as dependencies via Chart.yaml (rather than including them directly in the charts/ directory) seems to resolve the issue. In local testing, this fixes the problem, and when this PR is merged I will confirm it still works as expected for installing from the remote repository. This new layout is similar to what we tried previously, except that the subcharts of stack are in an "internal" directory rather than the top level, to signify that they are not useable in isolation.
- Loading branch information
obs-gh-jeremyjackins
authored
May 3, 2023
1 parent
1fea653
commit 59ab873
Showing
15 changed files
with
32 additions
and
9 deletions.
There are no files selected for viewing
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
dependencies: | ||
- name: fluent-bit | ||
repository: https://fluent.github.io/helm-charts | ||
version: 0.25.0 | ||
digest: sha256:b1fb614f3fe47886c997ab9f3fd952ad2558b0007c292553d66f9b7500262d52 | ||
generated: "2023-05-03T14:00:45.012194-07:00" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
dependencies: | ||
- name: logs | ||
repository: file://../internal/logs | ||
version: 0.1.0 | ||
- name: metrics | ||
repository: file://../internal/metrics | ||
version: 0.1.0 | ||
- name: events | ||
repository: file://../internal/events | ||
version: 0.1.2 | ||
digest: sha256:0ff59089263ba806f216691434b7d0fb1df7212a89c04bcebb802f5370b327bb | ||
generated: "2023-05-03T14:01:19.620154-07:00" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.