Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3081 Unsats caused by an issue involving tail #3094

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

aleixpuigb
Copy link
Collaborator

Fixes #3081 Unsats caused by an issue involving tail

Fixes #3081 Unsats caused by an issue involving tail
@aleixpuigb
Copy link
Collaborator Author

#gogoeditdiff

@github-actions
Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2023-10-19/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/uberon-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/uberon/releases/2023-10-19/uberon-simple.owl
  • Loaded from: file:/work/src/ontology/uberon-simple.owl

Ontology imports

Ontology annotations

post-anal tail bud http://purl.obolibrary.org/obo/UBERON_0002533

Removed

Added

@github-actions
Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/../../master/src/ontology/uberon-edit.obo

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/uberon/core.owl
  • Version IRI: None
  • Loaded from: file:/work/src/ontology/uberon-edit.obo

Ontology imports

Ontology annotations

post-anal tail bud http://purl.obolibrary.org/obo/UBERON_0002533

Removed

@aleixpuigb aleixpuigb requested a review from a user October 20, 2023 09:52
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defer to @gouttegd's assessment.
No unsats identified after reasoning in Protégé.

Copy link
Collaborator

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the PR fixes all the tail-related unsats that were found in #2928. Thanks!

@aleixpuigb aleixpuigb merged commit c776baf into master Oct 23, 2023
1 check passed
@aleixpuigb aleixpuigb deleted the 3081_fix_unsats_tail branch October 23, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsats caused by an issue involving tail (UBERON:0002415)
2 participants