Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ad hoc synonym type "layperson" with OMO:0003003 #10241

Closed
wants to merge 3 commits into from

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Nov 21, 2023

Closes #10140

@matentzn can you help me update the configuration to properly import the OMO term?

Closes obophenotype#10140

@matentzn can you help me update the configuration to properly import the OMO term?
@cthoyt cthoyt changed the title Replace _ad hoc_ synonym type "layperson" with OMO:0003003 Replace ad hoc synonym type "layperson" with OMO:0003003 Nov 21, 2023
@matentzn
Copy link
Contributor

I have seen this but there are right now a lot of competing priorities, sorry. While this PR is 100% correct and part of our overall vision, this needs a bit more careful thinking around communication. I have my eyes on it.

@matentzn matentzn self-assigned this Dec 8, 2023
@pnrobinson
Copy link
Contributor

What exactly is OMO and what advantage is this for us? I am concerned about keeping things easy to use for curators and users, and having our own definition of plain-language term seems reasonable since what is a layperson will differ according to context and surely any software using this will know all about HPO?

@matentzn
Copy link
Contributor

@pnrobinson there is no advantage for HPO; but also not a big disadvantage. The advantage is for cross-ontology integration. We want to be able to query for layperson synonyms of terms across ontologies (say MONDO, MAXO, HPO, Uberon etc) using a single standardised query. OMO is a vocabulary for ontology metadata properties where we standardise all properties used across all ontologies - we have already done a lot of this in HPO in the past year, these are just the last pieces of that process.

@pnrobinson
Copy link
Contributor

I am going to close this for now. If anybody needs this, it is trivial to map the current lay person label. I think we need to keep the file as simple as possible and only add things that are not immediately obvious (e.g., an URI) if there is a real need.

@pnrobinson pnrobinson closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize http://purl.obolibrary.org/obo/hp#layperson to OMO:0003003
3 participants