Add taxon subsets #2810
Closed
Add taxon subsets #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two new subsets: human-view and mouse-view. They are automatically generated by applying the taxon constraints declared in the ontology to exclude any class that can be inferred not to exist in human and mouse, respectively. This is the same strategy as used to produce similar subsets in Uberon, and is reusing the `create-species-subset` custom ROBOT command developed to that effect in the Uberon ROBOT plugin.
Now that we can generate tag files for the taxon subsets, we merge those into the main cl.owl release artefact. This requires that we no longer build the taxon subsets from the same release artefact, to avoid an obvious chicken-and-egg problem. So we now generate the subsets from cl-full.owl instead (which is, in effect, almost the same thing as cl.owl, modulo the ontology annotation).
In the preprocess step, where we make use of the FlyBase ROBOT plugin, make the 'all_robot_plugins' target an order-only prerequisite, so that once the plugins have been installed, we do not always trigger a rebuild of the preprocessed ontology, which in turn would trigger a rebuild of everything else.
The subset files are generated upon every release and are release artefacts, there is no need to commit them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds taxon-specific subsets to CL.
A taxon-specific subset for a given taxon is automatically generated by using the taxon constraints declared in the ontology to exclude any class that, due to the constraints, is known not to exist in the taxon. This is the same approach used for similar subsets in Uberon (obophenotype/uberon#3363).
Two new release artefacts are added:
human-view.owl(the human-specific subset) andmouse-view.owl(the mouse-specific subset). In addition, in the main release product (cl.owl), classes that were found to belong in the human (respectively mouse) subset are tagged with ahttp://purl.obolibrary.org/obo/cl#human_subset(respectivelyhttp://purl.obolibrary.org/obo/cl#mouse_subset) subset annotation (again, similar to what was done in Uberon).