-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reasoned and remove any disjoint #17
base: master
Are you sure you want to change the base?
Conversation
Made changes to Makefile
because mac uses python2 by default sigh...
removed all disjoint and owl:nothing equiv
owl:annotatedProperty rdfs:subClassOf ; | ||
owl:annotatedTarget ?sup ; | ||
oio:is_inferred ?inferred ] . | ||
} | ||
} | ||
FILTER (STRSTARTS(STR(?sup), "http://purl.obolibrary.org/obo/UBERON_")) | ||
# Can't get double filter to work! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dosumis The "UBERON_0002616" filter technically can work, however, many classes are mapped to "UBERON_0002616" (wrongly so for now) - adding this filter would remove a lot of classes that are in and need fixing rather than removal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the idea was to remove very general classifications that come in through inference, rather than assertion as with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is, strangely enough, 8266 terms (around half of all terms) that are subclass of http://purl.obolibrary.org/obo/UBERON_0002616, all of which are inferred. I've uploaded the terms here: https://github.com/obophenotype/ABA_Uberon/blob/b1a0daed3376f10719c6d8dc2d246772bb5bf157/src/ontology/report/uberon0002616.tsv
report on uberon0002616 terms
# Conflicts: # src/ontology/Makefile # src/robot_templates/linkouts.tsv
This branch is with reason and I removed disjoint and owl:Nothing equiv classes
I've also regenerated the report comparing the original (in master) report vs one generated by this