Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixing formats and media types #183

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

mixing formats and media types #183

wants to merge 6 commits into from

Conversation

c2bo
Copy link
Member

@c2bo c2bo commented Oct 17, 2024

closes #38
closes #168
closes #137

Rendered preview: https://drafts.oauth.net/draft-ietf-oauth-status-list/c2bo/mixing-formats/draft-ietf-oauth-status-list.html

This PR attempts to add a bit of language about mixing formats and also changes the content-type in the status list response to SHOULD and language around content type parsing that is similar to the language used in HTTP/1.1.

I am happy to remove the media types part if we want a bit more discussion, but when I started writing this, it felt like right path so I decided to include it as a proposal.

@c2bo c2bo marked this pull request as ready for review October 17, 2024 09:15
Co-authored-by: Tobias Looker <[email protected]>
Copy link
Contributor

@paulbastian paulbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not feeling confident with the change of MUST -> SHOULD for media type return. Maybe "MUST .. unless media type is known out-of-band"?


In the successful response, the Status List Provider MUST use the following content-type:
In the successful response, the Status List Provider SHOULD use the following content-type:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this work for you @paulbastian?

Suggested change
In the successful response, the Status List Provider SHOULD use the following content-type:
In the successful response, the Status List Provider MUST use the following content-type unless known out of band:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants