-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/recover from failed branch deletions #137
Conversation
@@ -614,9 +614,11 @@ export default function taoExtensionReleaseFactory(params = {}) { | |||
log.doing('Clean up the place'); | |||
|
|||
try { | |||
await gitClient.deleteBranch(data.releasingBranch); | |||
await gitClient.deleteBranch(data.releasingBranch); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a second possibility, using if (gitClient.hasBranch)
and no error.message
check, instead of try/catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @oatymart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is worth a try. However, if a further git action is needed and the refs cannot be resolved it might still break on the next step. Let's see how it goes.
Follow-up to #134
I noticed our
release-packages.yml
workflow failing in a few places:Based on the error messages, I think it could be the same problem that was addressed in #134 (but we should catch more error messages than we do).
This PR is a bit of a shot in the dark (untested). Looking for a second opinion before propagating to one of the broken workflows.