Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: attach labels to release, update CI #102

Merged
merged 8 commits into from
Aug 2, 2023
Merged

Conversation

azaitsau
Copy link
Contributor

@azaitsau azaitsau commented Aug 1, 2023

it was created from the origin PR: #100 that was created by Edwin

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Coverage Report

Totals Coverage
Statements: 51.85% ( 727 / 1402 )
Methods: 38.02% ( 92 / 242 )
Lines: 52.01% ( 401 / 771 )
Branches: 60.15% ( 234 / 389 )

StandWithUkraine

@azaitsau azaitsau changed the title chore: update version of coverage-monitor-action chore: attach lavles to release, update CI Aug 1, 2023
@azaitsau azaitsau changed the title chore: attach lavles to release, update CI chore: attach labels to release, update CI Aug 1, 2023
Copy link
Contributor

@oatymart oatymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of functionality, it looks like what I tested successfully before. @edwin-focaloid Please can you bring the code formatting up to our standard before I finalise the review?

src/release.js Outdated Show resolved Hide resolved
tests/unit/release/createPullRequest/release.spec.js Outdated Show resolved Hide resolved
src/github.js Outdated Show resolved Hide resolved
Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@edwin-focaloid edwin-focaloid merged commit e9301e7 into develop Aug 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants