Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new container rebuild function that restarts as well #3901

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

augustas
Copy link
Contributor

@augustas augustas commented Oct 9, 2023

Using another function to rebuild DI container.

Related to : https://oat-sa.atlassian.net/browse/REL-1275

Dependencies

Requires :

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f2bdc93) 27.55% compared to head (53ff754) 27.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #3901   +/-   ##
==========================================
  Coverage      27.55%   27.55%           
  Complexity     10976    10976           
==========================================
  Files            922      922           
  Lines          33914    33910    -4     
==========================================
  Hits            9345     9345           
+ Misses         24569    24565    -4     
Files Coverage Δ
actions/class.ExtensionsManager.php 47.19% <0.00%> (+1.03%) ⬆️
install/class.Installator.php 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Version

Target Version 53.8.0
Last version 53.7.3

There are 0 BREAKING CHANGE, 1 feature, 1 fix

Copy link
Contributor

@vbyndych vbyndych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code respects code style rules
  • New code respects best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic

@vbyndych vbyndych self-assigned this Oct 10, 2023
@augustas augustas merged commit 86fb138 into develop Oct 10, 2023
4 checks passed
@augustas augustas deleted the feat/REL-1275/rebuild-di-container branch October 10, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants