fix: fix markers population in generis.conf #3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KirylHatalski
requested review from
andreluizmachado,
bartlomiejmarszal and
Karol-Stelmaczonek
Codecov Report
@@ Coverage Diff @@
## develop #3860 +/- ##
=============================================
- Coverage 27.58% 27.58% -0.01%
- Complexity 10972 10975 +3
=============================================
Files 922 922
Lines 33900 33909 +9
=============================================
+ Hits 9351 9353 +2
- Misses 24549 24556 +7
|
|
if it works for concatenated .env strings then is a great change |
serge-salamanka
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
andreluizmachado
requested review from
bartlomiejmarszal and
Karol-Stelmaczonek
Karol-Stelmaczonek
approved these changes
Aug 16, 2023
hectoras
reviewed
Aug 16, 2023
Co-authored-by: Héctor Arroyo <[email protected]> Signed-off-by: Kiril Hatalski <[email protected]>
Version❕ Some commits are not using the conventional commits formats. They will be ignored in version management.
There are 0 BREAKING CHANGE, 0 feature, 3 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for markers placement in
generis.conf.php.Example of .env usage:
AWS_STACK_CONFIG_ORIGIN=tao-community.docker.localhost/ AWS_STACK_CONFIG_SOURCE=ontologies/tao.rdf AWS_STACK_CONFIG_NAMESPACE=https://${AWS_STACK_CONFIG_ORIGIN}${AWS_STACK_CONFIG_SOURCE}Example of
seed.jsonusage:"global": { "lang": "en-US", "mode": "debug", "instance_name": "tao-community", "namespace": "$ENV{AWS_STACK_CONFIG_NAMESPACE}", "url": "https://tao.docker.localhost/", "session_name": "tao_community", "timezone": "Europe/Luxembourg", "import_data": true },Fix contain extension for .env operation scope on installation step and additional type of insertion for parsed from configs markers.
Also fix contain logging change, for reducing logs doublication.