fix: fix copy of copied classes

[tikhanovichA]

https://oat-sa.atlassian.net/browse/ADF-1545

We need to fix the possibility of copying already copied classes.

How to test:

1. Go to items and create a new folder/class
2. Copy this class
3. Try to copy the folder you got in step 2

[uncleempty]

In general it's ok.
Just one question:
maybe it's better to create $copyIdentifier in the doCopy method instead of creating it higher and providing to each call of this method? Because as far as I can see all the needed args are also available inside. And this will make changes way less intrusive.

[shpran]

I prefer to use null as default instead of empty string 🙂

Suggested change

	string $copyIdentifier = '',
	?string $copyIdentifier = null,

[github-actions]

Version

Target Version	53.4.1
Last version	53.4.0

There are 0 BREAKING CHANGE, 0 feature, 5 fixes

[hectoras]

TL;DR: Maybe this can be solved by simply declaring ResourceTransferProxy in the DI contanier as non-shared.

I think this happens because the class copier is instantiated once by a given worker and then it "remembers" the IDs for the classes it copied for prior requests. And I think this happens because the service is instantiated once from the DI container and then reused for each task run by the worker, so wouldn't it be easier to just declare the services form the DI container as non-shared so their state is not remembered across invocations (here)?

Specifically, I think this may be happening because ResourceTransferProxy receives a ClassCopierProxy instance when it is constructed: ClassCopierProxy is non-shared, but ResourceTransferProxy is, so it retains a reference to the previous ClassCopierProxy instance either way.

Note here the problem is caused by having a service that is statefull (ClassCopier having $copiedClasses) and we are trying to solve the issue by adding more state (which "operation" the copy belongs to). There is another problem (that was there before) related to memory usage: A copier instantiated by a worker will be increasing the worker memory footprint each time is invoked (by storing the copied classes and now also an additional operation ID per copy operation).

[tikhanovichA]

Will be closed for solving it as @hectoras proposed.